Skip to content

Update all examples #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Update all examples #1922

merged 1 commit into from
Sep 6, 2024

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Sep 6, 2024

Mostly:

  • use latest version in package.json
  • use nodejs20.x runtime
  • add some missing README

I removed serverless-offline from plugins because it was never used

@j0k3r j0k3r added the dependencies Pull requests that update a dependency file label Sep 6, 2024
@j0k3r j0k3r requested a review from vicary September 6, 2024 09:56
Copy link
Member

@vicary vicary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since serverless-offline is being removed from serverless.yml in all examples, should we also remove them from package.json files?

@j0k3r j0k3r requested a review from vicary September 6, 2024 10:26
Copy link
Member

@vicary vicary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mostly:
- use latest version in `package.json`
- use `nodejs20.x` runtime
- add some missing README
- remove serverless-offline deps
@j0k3r j0k3r force-pushed the fix/update-examples branch from b723cb7 to e915ce4 Compare September 6, 2024 12:13
@j0k3r j0k3r enabled auto-merge September 6, 2024 12:13
@j0k3r j0k3r merged commit 76da4f3 into master Sep 6, 2024
13 checks passed
@j0k3r j0k3r deleted the fix/update-examples branch September 6, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants