Skip to content

Fix the ScriptProcessExecutor to honor the await property #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix the ScriptProcessExecutor to honor the await property #488

merged 1 commit into from
Jan 23, 2025

Conversation

toxik
Copy link
Contributor

@toxik toxik commented Jan 23, 2025 •
edited by cdavernas
Loading

What this PR does / why we need it:

  • Fixes the ScriptProcessExecutor to honor the await property

@toxik
fix(Runner): honor await property
b780dc1 
fixes serverlessworkflow#487

Signed-off-by: Alexandru Georoceanu <alex@navigheaza.ro>
cdavernas
cdavernas approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheets ❤️

@cdavernas cdavernas changed the title fix(Runner): honor await property Fix the ScriptProcessExecutor to honor the await property Jan 23, 2025
@cdavernas cdavernas added priority: high Indicates a high priority issue weight: 1 An issue that has a very low development impact app: runner Concerns the Runner type: fix labels Jan 23, 2025
@cdavernas cdavernas added this to the v1.0.0 milestone Jan 23, 2025
@cdavernas cdavernas merged commit 2e23c25 into serverlessworkflow:main Jan 23, 2025
1 check passed
@cdavernas cdavernas linked an issue Jan 23, 2025 that may be closed by this pull request
Scripts are not awaited by default #487
Closed
@toxik toxik deleted the fix/script-task branch February 12, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavernas cdavernas cdavernas approved these changes

Assignees

@toxik toxik

Labels
app: runner Concerns the Runner priority: high Indicates a high priority issue type: fix weight: 1 An issue that has a very low development impact
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Scripts are not awaited by default
2 participants
@toxik @cdavernas