Fixed both the ClusterResourceController and NamespacedResourceController by ensuring that SSE-based actions do not set the response's status code after streaming
#514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esourceController` by ensuring that SSE-based actions do not set the response's status code after streaming Fixes #508 Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a fundamental issue with Server-Sent Events (SSE) implementation in both ClusterResourceController and NamespacedResourceController by preventing the setting of HTTP status codes after streaming has begun. The changes ensure proper SSE streaming behavior while maintaining error handling capabilities.
- Modified SSE action methods to return
Taskinstead ofIActionResultto avoid status code conflicts - Refactored error handling to write responses directly to the HTTP response stream
- Consolidated JSON serialization dependency in the base
ResourceControllerclass
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Usings.cs | Added System.Net.Mime namespace for content type constants |
| ResourceController.cs | Added JSON serializer dependency and helper methods for direct response writing |
| NamespacedResourceController.cs | Updated SSE methods to avoid status code setting after streaming |
| ClusterResourceController.cs | Updated SSE methods to avoid status code setting after streaming |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
ClusterResourceControllerandNamespacedResourceControllerby ensuring that SSE-based actions do not set the response's status code after streaming