Fixed the WorkflowInstanceController to ignore instances of unselected workflows
#528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nces of unselected workflows Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the WorkflowInstanceController where the controller was not properly handling workflow instances that belong to unselected workflows. The fix ensures that when a workflow cannot be retrieved from the cache (indicating it was filtered out by selectors), the associated workflow instances are also ignored.
Key changes:
- Improved the logic for determining if a workflow instance should be processed by the controller
- Added explicit handling for cases where the associated workflow is not found in the cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
WorkflowInstanceControllerto ignore instances of unselected workflowsFixes #527