Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Decouple egui as optional feature for servoshell #34840

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dklassic
Copy link
Contributor

@dklassic dklassic commented Jan 6, 2025

Decoupled egui as optional feature for servoshell, so servoshell may be used as a webview library.


  • There are tests for these changes OR
  • These changes do not require tests because this is just a feature refactor without function change

Signed-off-by: DK Liao <dklassic@gmail.com>
Signed-off-by: DK Liao <dklassic@gmail.com>
@dklassic dklassic requested a review from atbrakhi as a code owner January 6, 2025 08:35
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can take this time to move minibrowser and egui_glow modules into a egui module directory, and rename minibrowser to egui_browser.

@mrobinson
Copy link
Member

I would prefer not to do this, as this undoes the change we made when making servoshell (converting a port into the default minibrowser). Instead if there are things that should be part of the servo API, they should be moved gradually into libservo.

@wusyong
Copy link
Member

wusyong commented Jan 6, 2025

@mrobinson I'm fine not to add this for now, but we still need to iterate the current servo shell (or servo itself) that can draw its own chrome in the end. Is it okay to bring winit code to libservo later on? Because I believe you mentioned we don't want another port with duplicated code already.

For reference, chromium does have different frameworks like aura and ozone for windowing to different platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants