script: Expose NodeTraits::owner_global / Window::as_global_scope
#34843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51861fd to
80c31e4
Compare
jdm
approved these changes
Jan 7, 2025
Expose two new helpers and start using them as much as possible. - `NodeTraits::owner_global`: which gets the `GlobalScope` that currenty owns a `Node`. This may be different than `.global()` in the case that the `Node` was adopted by a different `Document`. - `Window::as_global_scope`: A helper to avoid having to cast so much when treating a `Window` like a `GlobalScope`. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
80c31e4 to
e6415e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose two new helpers and start using them as much as possible.
NodeTraits::owner_global: which gets theGlobalScopethat currentyowns a
Node. This may be different than.global()in the case thatthe
Nodewas adopted by a differentDocument.Window::as_global_scope: A helper to avoid having to cast so muchwhen treating a
Windowlike aGlobalScope.Signed-off-by: Martin Robinson mrobinson@igalia.com
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors