Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: Downgrade noisy debug logs. #34914

Merged
merged 1 commit into from
Jan 9, 2025
Merged

script: Downgrade noisy debug logs. #34914

merged 1 commit into from
Jan 9, 2025

Conversation

jdm
Copy link
Member

@jdm jdm commented Jan 9, 2025

Every time I use RUST_LOG=script=debug I regret it. These particular log messages are low signal and high noise.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they are debug logs.

@jdm
script: Downgrade noisy debug logs.
9d4ee49 
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm requested a review from gterzian as a code owner January 9, 2025 07:04
@jdm jdm enabled auto-merge January 9, 2025 07:40
@jdm jdm added this pull request to the merge queue Jan 9, 2025
Merged via the queue into servo:main with commit 3d1b7f8 Jan 9, 2025
23 checks passed
@jdm jdm deleted the less-info branch January 9, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delan delan delan approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdm @delan