change conversion to appunit from float of percentage calcuation #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Since we want to test this before publishing a new release of app units, let's inline the code here for now. |
|
BTW, when creating a PR it's better not to use your main branch. |
Loirooriol
added a commit
to Asun0204/servo
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
added a commit
to Asun0204/servo
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
reviewed
Jan 8, 2025
There was a problem hiding this comment.
It may make more sense to modify this instead:
stylo/style/values/computed/length.rs
Lines 496 to 501 in 7e529e8
I thought that would be more likely to affect Firefox, but I have tried commenting that (and its callers) out, and Firefox compiles fine, so it's not used.
prevent the situation that child box size is calculated too large. Signed-off-by: Asun0204 <Asun0204@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change conversion to appunit from float of percentage calcuation, prevent child box size is calculated too large.