Skip to content

Commit da40720

Browse files
committed
Return NativeImage in BrowserWindow.capturePage
1 parent 443a4b8 commit da40720

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

atom/browser/api/atom_api_window.cc

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,11 @@ namespace {
5252

5353
void OnCapturePageDone(
5454
v8::Isolate* isolate,
55-
const base::Callback<void(v8::Handle<v8::Value>)>& callback,
55+
const base::Callback<void(const gfx::Image&)>& callback,
5656
const std::vector<unsigned char>& data) {
5757
v8::Locker locker(isolate);
5858
v8::HandleScope handle_scope(isolate);
59-
60-
v8::Local<v8::Value> buffer = node::Buffer::New(
61-
reinterpret_cast<const char*>(data.data()),
62-
data.size());
63-
callback.Run(buffer);
59+
callback.Run(gfx::Image::CreateFrom1xPNGBytes(&data.front(), data.size()));
6460
}
6561

6662
} // namespace
@@ -374,7 +370,7 @@ bool Window::IsDocumentEdited() {
374370

375371
void Window::CapturePage(mate::Arguments* args) {
376372
gfx::Rect rect;
377-
base::Callback<void(v8::Handle<v8::Value>)> callback;
373+
base::Callback<void(const gfx::Image&)> callback;
378374

379375
if (!(args->Length() == 1 && args->GetNext(&callback)) &&
380376
!(args->Length() == 2 && args->GetNext(&rect)

vendor/native_mate

0 commit comments

Comments
 (0)