Skip to content

Update ls with glob example. #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

Update ls with glob example. #1006

merged 1 commit into from
Sep 3, 2020

Conversation

smack0007
Copy link
Contributor

Adding an example of using ls with globs. Will generate the README soon.

@smack0007 smack0007 changed the title WIP: Update ls.js Update ls with glob example. Aug 28, 2020
@smack0007
Copy link
Contributor Author

I just added an example of using a glob pattern with ls. As a windows user this wasn't immediately obvious to me.

@smack0007
Copy link
Contributor Author

I took a look at the failed builds and I have no idea what to do. I only added a single comment to a function's description and regenerated the docs. Please advise.

@nfischer
Copy link
Member

nfischer commented Sep 1, 2020

It looks like you did everything right, but maybe the test has become flaky. Can you trigger a rebuild of the PR? I can't find the "rebuild" button in the Travis UI anymore.

The "brute force" way to trigger a rebuild is to git commit --amend --no-edit && git push -f origin patch-2 (from your local branch).

nfischer
nfischer approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is otherwise fine. If you can't easily trigger a Travis rebuild, I'll look at merging this as-is.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #1006 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          35       35           
  Lines        1332     1332           
=======================================
  Hits         1295     1295           
  Misses         37       37
Impacted Files Coverage Δ
src/ls.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8452b8...20af141. Read the comment docs.

@smack0007
Update ls.js
20af141 
Adding example of using ls with globs.
@nfischer nfischer merged commit ba5d782 into shelljs:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfischer nfischer nfischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smack0007 @nfischer @codecov-commenter