Skip to content

test(cmd): add test for caret char #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

test(cmd): add test for caret char #1017

merged 1 commit into from
Feb 8, 2021

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Feb 8, 2021

No change to logic. This adds a test case to make sure the caret
character ('^') is passed through to the command. This is to make sure
the character is not treated specially on Windows, where it's an escape
character in the shell.

Fixes #1015

No change to logic. This adds a test case to make sure the caret
character ('^') is passed through to the command. This is to make sure
the character is not treated specially on Windows, where it's an escape
character in the shell.

Fixes #1015
@codecov-io
Copy link

Codecov Report

Merging #1017 (d1c6349) into master (355bc75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1017   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          35       35           
  Lines        1332     1332           
=======================================
  Hits         1295     1295           
  Misses         37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355bc75...d1c6349. Read the comment docs.

@nfischer nfischer merged commit cb64b92 into master Feb 8, 2021
@nfischer nfischer deleted the test-cmd-caret-char branch February 8, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command with caret doesn't work as supposed to with exec()
2 participants