Skip to content

Feature: Expose Error Code #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2022
Merged

Conversation

JessieFrance
Copy link
Contributor

This PR is for part of #1013, and aims to implement shell.errorCode(), similar to shell.error(). Please let me know if you'd like me to change something, and thank you for the chance to work on a new ShellJS feature!

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #1036 (6d6a8f9) into master (79ae14d) will decrease coverage by 1.48%.
The diff coverage is 100.00%.

❗ Current head 6d6a8f9 differs from pull request most recent head 90e8c8c. Consider uploading reports for the commit 90e8c8c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
- Coverage   97.14%   95.65%   -1.49%     
==========================================
  Files          35       36       +1     
  Lines        1332     1336       +4     
==========================================
- Hits         1294     1278      -16     
- Misses         38       58      +20     
Impacted Files Coverage Δ
shell.js 100.00% <100.00%> (ø)
src/errorCode.js 100.00% <100.00%> (ø)
src/rm.js 85.07% <0.00%> (-11.95%) ⬇️
src/cp.js 86.40% <0.00%> (-4.80%) ⬇️
src/test.js 95.23% <0.00%> (-4.77%) ⬇️
src/ln.js 96.87% <0.00%> (-3.13%) ⬇️
src/cmd.js 97.05% <0.00%> (-2.95%) ⬇️
src/mkdir.js 94.44% <0.00%> (-2.78%) ⬇️
src/chmod.js 87.05% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ae14d...90e8c8c. Read the comment docs.

Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small comment inline.

@JessieFrance JessieFrance requested a review from nfischer July 13, 2021 16:25
@nfischer nfischer merged commit 403a57c into shelljs:master Jan 15, 2022
@nfischer nfischer added this to the v0.9.0 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants