Skip to content

Added -L to find to visit symlinked folders too. #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

mperrando
Copy link
Contributor

Actually find does not go inside a symlink that is a folder.

In order to preserve old behaviour, the -L flag has been introduced to modify the behaviour and enter symlink'ed folders.

Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems reasonable overall

@nfischer nfischer added bash compat Compatibility issues with bash or POSIX behavior feature labels Feb 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1080 (d22bb03) into master (4b6b17a) will decrease coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
- Coverage   97.19%   96.38%   -0.82%     
==========================================
  Files          36       36              
  Lines        1354     1354              
==========================================
- Hits         1316     1305      -11     
- Misses         38       49      +11     
Impacted Files Coverage Δ
src/find.js 95.45% <100.00%> (-4.55%) ⬇️
src/which.js 80.00% <0.00%> (-15.00%) ⬇️
src/cmd.js 94.11% <0.00%> (-5.89%) ⬇️
src/ln.js 96.87% <0.00%> (-3.13%) ⬇️
src/ls.js 97.67% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6b17a...d22bb03. Read the comment docs.

@nfischer nfischer merged commit 8c926df into shelljs:master Feb 25, 2022
@nfischer nfischer added this to the v0.9.0 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash compat Compatibility issues with bash or POSIX behavior feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants