Skip to content

chore: remove unsupported node configs from CI #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Jun 1, 2024

No change to logic. GitHub Actions recently dropped some NodeJS configurations from their service. This excludes those configs from our CI.

This also adds Node versions up through v22.

Test: npm run check-node-support

@nfischer nfischer added the chore label Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (2ff87ef) to head (1683552).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          36       36           
  Lines        1360     1360           
=======================================
  Hits         1323     1323           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

No change to logic. GitHub Actions recently dropped some NodeJS configurations from their service. This excludes those configs from our CI.

This also adds Node versions up through v22.

Test: npm run check-node-support
@nfischer nfischer force-pushed the chore-drop-node-v12 branch from c9c39a9 to 1683552 Compare June 1, 2024 19:01
@nfischer nfischer merged commit 3529d50 into master Jun 1, 2024
@nfischer nfischer deleted the chore-drop-node-v12 branch June 1, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant