test: add more coverage for globOptions #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 36 36
Lines 1360 1360
=======================================
Hits 1323 1323
Misses 37 37 ☔ View full report in Codecov by Sentry. |
No change to logic. This adds tests for more `config.globOptions` values. This aims to cover the options which appear to be supported by both node-glob and fast-glob, however the options have different names in each module. This is a followup to PR #1163. See https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob Issue #828
ccbb255 to
7a5f9a4
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to logic. This adds tests for more
config.globOptionsvalues. This aims to cover the options which appear to be supported by both node-glob and fast-glob, however the options have different names in each module. This is a followup to PR #1163.See https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#compatible-with-node-glob
Issue #828