chore: drop support for old node versions #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 36 36
Lines 1361 1361
=======================================
Hits 1324 1324
Misses 37 37 ☔ View full report in Codecov by Sentry. |
f2cf6eb to
a9014dc
Compare
kmashint
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Works for me cleanly on Windows 10, node 18.20.6. Had the known failures with pushd and popd on node 22.9.0.
2 tests failed
6 tests skipped
pushd » quiet mode off
D:\_Project\shelljs-kmashint\test\resources\pushd\test\pushd.js:343
Difference:
- `D:\\_Project\\shelljs-kmashint\\test\\resources\\pushd D:\\_Project\\shelljs-kmashint␊
+ `D:\\_Project\\shelljs-kmashint\\test\\resources\\pushd D:\\_Project\\shelljs-kmashint␊
`
popd » quiet mode off
D:\_Project\shelljs-kmashint\test\popd.js:130
129: t.is(stdout, '');
130: t.is(stderr, `${rootDir}\n`);
131: t.is(process.cwd(), trail[0]);
Difference:
- `D:\\_Project\\shelljs-kmashint␊
+ `D:\\_Project\\shelljs-kmashint␊
c470678 to
2d393ac
Compare
Dropping support for everything before node v18, which is the current maintenance LTS and also the version in Ubuntu 24.04 LTS. This also updates all devDependencies while trying to minimize the required source code changes. Some devDependencies can go higher still (ava, chalk), but this is going to require extensive refactoring. Test: npm run test-with-coverage Test: npm run lint Test: npm run check-node-support
2d393ac to
2c6d8c9
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping support for everything before node v18, which is the current
maintenance LTS and also the version in Ubuntu 24.04 LTS.
This also updates all devDependencies while trying to minimize the
required source code changes. Some devDependencies can go higher still
(ava, chalk), but this is going to require extensive refactoring.
Test: npm run test-with-coverage
Test: npm run lint
Test: npm run check-node-support