Skip to content

refactor: rewrite gendocs script without commands.js #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

nfischer
Copy link
Member

The gendocs script no longer depends on commands.js. This now works by iterating over source files and parsing them directly.

Partially related to issue #1160 and #1172.
Test: npm run gendocs

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (5193084) to head (9e7d825).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          36       36           
  Lines        1380     1380           
=======================================
  Hits         1343     1343           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfischer nfischer force-pushed the refactor-gendocs-script branch from f6e953e to fc210e1 Compare February 20, 2025 08:33
The gendocs script no longer depends on commands.js. This now works by
iterating over source files and parsing them directly.

Partially related to issue #1160 and #1172.
Test: npm run gendocs
@nfischer nfischer force-pushed the refactor-gendocs-script branch from fc210e1 to 9e7d825 Compare February 20, 2025 08:34
@nfischer nfischer merged commit fca5f1b into master Feb 20, 2025
20 checks passed
@nfischer nfischer deleted the refactor-gendocs-script branch February 20, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant