Skip to content

test: document test for newline in cmd() function #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Feb 22, 2025

No change to logic. This adds documentation for the test case for
handling newlines.

This also removes a nearby eslint suppression which is no longer
necessary after PR #1184.

Fixes #175

@nfischer nfischer added the test label Feb 22, 2025
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (fca5f1b) to head (3caf439).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          36       36           
  Lines        1380     1380           
=======================================
  Hits         1343     1343           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

No change to logic. This adds documentation for the test case for
handling newlines.

This also removes a nearby eslint suppression which is no longer
necessary after PR #1184.

Fixes #175
@nfischer nfischer changed the title test: simplify test for newline in cmd() function test: document test for newline in cmd() function Feb 22, 2025
@nfischer nfischer added the exec Issues specific to the shell.exec() API label Feb 22, 2025
@nfischer nfischer merged commit f29a7a8 into master Feb 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exec Issues specific to the shell.exec() API test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command can't have \n
1 participant