refactor: follow up fixes for static imports #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change to logic. This is a follow up to PR #1119. This change: * Deletes commands.js entirely and edits the 'files' section of package.json * Undoes some duplicate imports (ex. src/error) * Adds an explicit import for exec-child.js as a hint for the bundler After this change, I expect that bundlers/minifiers such as esbuild will now correctly process shelljs. Fixes #1160
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
- Coverage 97.37% 97.37% -0.01%
==========================================
Files 35 35
Lines 1410 1408 -2
==========================================
- Hits 1373 1371 -2
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to logic. This is a follow up to PR #1119. This change:
After this change, I expect that bundlers/minifiers such as esbuild will now correctly process shelljs.
Fixes #1160