Update node to version 20 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwittwer
requested changes
Apr 2, 2024
michaelwittwer
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
When you merge the PR and the build was successful you can follow the instructions in the README file to create a new release by adding the git tag. Also the information about doing versioning without the v... was wrong. Keep using the v prefix according to this doc.
Since we don't have any tooling to create a CHANGELOG please also create a release on GitHub with some description about the changes:
When the release is done create a PR with using the new skip version in https://github.com/shiftcode/sc-commons-public/blob/main/.github/workflows/main.yml.
|
@vitaliibendyk please check the build which is currently failing. |
…thub-action-skip into #24-upgrade-node-to-v20
michaelwittwer
requested changes
Apr 4, 2024
michaelwittwer
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .nvmrc, update node 20.11