SG-38213 Prevent unexpected retries on error #379
Conversation
shotgun_api3/shotgun.py
Outdated
| except Exception as e: | ||
| self._close_connection() | ||
| if attempt == max_rpc_attempts: | ||
| LOG.debug("Request failed. Giving up after %d attempts." % attempt) | ||
| raise | ||
| LOG.debug(f"Request failed. Reason: {e}") | ||
| raise |
There was a problem hiding this comment.
Why do we even keep this except block then?
Just for the _close_connection?
There was a problem hiding this comment.
Here we can catch RemoteDisconected or some other error which I don't remember rn about ClosedConnection or something like that.
There was a problem hiding this comment.
I don't understand this answer.
There was a problem hiding this comment.
Ok let me summarize it: We use this except block for timeout or any other server error. And this is what's been happening with this ticket's context.
It seems this concern was already identified before. If any regression happened, that can help us identify better use cases (and we can always let the customers use the previous versions). |
shotgun_api3/shotgun.py
Outdated
| except Exception as e: | ||
| self._close_connection() | ||
| if attempt == max_rpc_attempts: | ||
| LOG.debug("Request failed. Giving up after %d attempts." % attempt) | ||
| raise | ||
| LOG.debug(f"Request failed. Reason: {e}") | ||
| raise |
There was a problem hiding this comment.
I don't understand this answer.
Co-authored-by: Julien Langlois <16244608+julien-lang@users.noreply.github.com>
We want to control when python-api does a retry on error.
SSLEOFErrorSSLHandshakeErrorOn
_make_callfunction.We don't want to retry on a general exceptions (e.g. Timeout or remote disconnection) because we might send a resource modification request (create, batch create, etc) and we can end up duplicating things.