SG-38877 Update certifi third party library to version2025.7.14 #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the bundled certifi library to version 2025.7.9, removes legacy fallback code, and refreshes the root CA bundle.
- Bump certifi version in requirements and package metadata
- Simplify
core.pyby removing the Python <3.7 fallback - Replace the CA certificate file with the updated root store and add new D-TRUST entries
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements.txt | Bump certifi from 2024.7.4 to 2025.7.9 |
| certifi/core.py | Remove the Python <3.7 fallback branch under where() |
| certifi/cacert.pem | Refresh CA bundle: remove outdated roots and add D-TRUST CAs |
| certifi/init.py | Update __version__ to 2025.07.09 |
Comments suppressed due to low confidence (3)
shotgun_api3/lib/certifi/cacert.pem:2
- A large number of root certificates were removed from the trust bundle; please confirm this change is intentional to avoid unexpected TLS trust failures.
# Issuer: CN=Entrust Root Certification Authority O=Entrust, Inc. OU=www.entrust.net/CPS is incorporated by reference/(c) 2006 Entrust, Inc.
shotgun_api3/lib/certifi/init.py:4
- [nitpick] After bumping the library version, consider updating associated release notes or documentation to reflect the new certifi version.
__version__ = "2025.07.09"
shotgun_api3/lib/certifi/core.py:49
- The fallback branch for Python <3.7 was removed; ensure that the project now requires Python ≥3.7 and update any compatibility documentation accordingly.
else:
carlos-villavicencio-adsk
previously approved these changes
Jul 11, 2025
carlos-villavicencio-adsk
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump certifi version to https://pypi.org/project/certifi/2025.7.14/
About certifi changes between
2024.12.14and2025.07.14certifi/python-certifi@2024.12.14...2025.07.14