SG-38306 Python2 Removal - Part 5 - Remove deprecated backported mock module #402
+38
−1,031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2025
Draft
33e5200 to
c4d1e30
Compare
f533371 to
e93ed1e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated backported mock module and updates tests to use Python’s built-in unittest.mock.
- Deleted the standalone
tests/mock.pyand its imports - Replaced patch and mock references with
unittest.mockcalls - Updated
.flake8to stop excluding the removedtests/mock.py
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_unit.py | Removed from .mock import patch, updated decorators to use mock.patch but needs to import mock |
| tests/test_client.py | Switched to unittest.mock for all mock calls |
| tests/test_api.py | Switched to unittest.mock and removed legacy imports |
| tests/mock.py | Deleted deprecated backported mock implementation |
| tests/base.py | Switched to unittest.mock in setup helpers |
| .flake8 | Removed tests/mock.py from exclude list |
Comments suppressed due to low confidence (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove now deprecated copy of the mock module.
We prefer to use Python's default unittest.mock module instead.
PR orders
WIP