CPython compatibility #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o foamyguy_cpython_compat # Conflicts: # adafruit_turtle.py
|
I did test this on Raspberry Pi and it does seem to work successfully on that platform as well. I am still open to other potential solutions as well if anyone has other ideas. |
|
Hey @FoamyGuy thank you so much for discovering and fixing these issues. I tested this on three setups as well:
It seems to work well on all of those platforms. I went ahead and merged these changes so we can continue with the other pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this version on PyPortal with circuitpython, as well as CPython with PyGameDisplay.
I am going to try to test on RasPi with just Blinka_DisplayIO as well.