Skip to content

Update travis and tox #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2014
Merged

Update travis and tox #287

merged 6 commits into from
Oct 29, 2014

Conversation

sigmavirus24
Copy link
Owner

Tox has some new features that I thought I would take advantage of and I wanted to add jobs for flake8

@esacteksab
Copy link
Contributor

This is hawt!

@sigmavirus24
Copy link
Owner Author

Thanks. I kind of wish there was a way to do generative testenv things (instead of having 3 different sections) but I suspect that's more a limitation of ini formatting.

sigmavirus24 added a commit that referenced this pull request Oct 29, 2014
@sigmavirus24 sigmavirus24 merged commit b091a1f into 1.0-alpha Oct 29, 2014
@sigmavirus24 sigmavirus24 deleted the 1.0-travis branch October 29, 2014 03:53
@msabramo
Copy link
Contributor

msabramo commented Nov 1, 2014

I kind of wish there was a way to do generative testenv things (instead of having 3 different sections)

Would this help?

msabramo added a commit to msabramo/github3.py that referenced this pull request Nov 1, 2014
These are the changes that @sigmavirus24 did to `tox.ini` on the
`1.0-alpha` branch in
sigmavirus24#287
@sigmavirus24
Copy link
Owner Author

So all of the generative stuff seems limited to env-list and the requirements sections. Which makes sense because the syntax I want is [testenv:py{26,27,py}] and I think at that point it might be a bit hairy to do right. Then again I should just ask on the TIP mailing list to see if I'm wrong about that not being supported (unless someone beats me to asking about it)

@sigmavirus24
Copy link
Owner Author

Thread started here

msabramo added a commit to msabramo/github3.py that referenced this pull request Nov 1, 2014
These are the changes that @sigmavirus24 did to `.travis.yml` on the
`1.0-alpha` branch in sigmavirus24#287
@msabramo
Copy link
Contributor

msabramo commented Nov 1, 2014

I have not played with it yet but I noticed that unittest2 on PyPI since unittest2 0.6.0 claims to now work with Python 3. This was always a big annoyance of mine; so much that I created unittest2six, which probably isn't necessary anymore.

So you might be to get rid of special-casing to not include unittest2 in py3 venvs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants