Skip to content

tox.ini: Tweak test discovery #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

tox.ini: Tweak test discovery #296

wants to merge 2 commits into from

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented Nov 2, 2014

Replace tests/ in addopts with norecursedirs

Better to filter than to add in a default, so as not to force folks to always run all the tests.

This is motivated by the comments on another PR: #294 (comment)

Note that the norecursedirs line might not even be necessary as pytest has fairly comprehensive defaults that might already handle the stuff that you're worried about. See http://pytest.org/latest/customize.html#confval-norecursedirs

Proof that it works:

$ tox -e py27 -- -v tests/integration/test_repos_release.py
GLOB sdist-make: /Users/marca/dev/git-repos/github3.py/setup.py
py27 inst-nodeps: /Users/marca/dev/git-repos/github3.py/.tox/dist/github3.py-0.9.2.zip
py27 runtests: PYTHONHASHSEED='2770156593'
py27 runtests: commands[0] | py.test -v tests/integration/test_repos_release.py
============================================================================= test session starts ==============================================================================
platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4
collected 6 items

tests/integration/test_repos_release.py ......

=========================================================================== 6 passed in 0.28 seconds ===========================================================================
___________________________________________________________________________________ summary ____________________________________________________________________________________
  py27: commands succeeded
  congratulations :)

$ tox -e py27
GLOB sdist-make: /Users/marca/dev/git-repos/github3.py/setup.py
py27 inst-nodeps: /Users/marca/dev/git-repos/github3.py/.tox/dist/github3.py-0.9.2.zip
py27 runtests: PYTHONHASHSEED='2676834291'
py27 runtests: commands[0] | py.test
..............................................x...............................................................................................................................................................................................................................................................................................................................................................................................................................................................
493 passed, 1 xfailed in 3.85 seconds
___________________________________________________________________________________ summary ____________________________________________________________________________________
  py27: commands succeeded
  congratulations :)

Closes #294.

@msabramo
tox.ini: Tweak test discovery
8ade1a0 
Replace `tests/` in `addopts` with `norecursedirs`

Better to filter than to add in a default, so as not to force folks to
always run all the tests.
This was referenced Nov 2, 2014
Closed
Merged
@sigmavirus24
Copy link
Owner

I don't think GitHub updates branches properly and this was in 1.0-alpha and so is now i develop. Thanks @msabramo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msabramo @sigmavirus24