Context data should be passed through to data dict #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug where context was always being set to `None` regardless of the value passed to `create_status`.
|
(Apologies for not providing a test case, I'm short of time and it seems like a fairly obvious/trivial mistake in the code) |
sigmavirus24
added a commit
that referenced
this pull request
Apr 8, 2015
Context data should be passed through to data dict
|
Do you need this in 0.9? |
|
@sigmavirus24 It would be good to have it if possible. I'm using a local modified copy now, but having the fix available through pip would be better for deployment. |
Feel free to cherry-pick your fix to the stable/0.9 branch and send a PRSent from my Android device with K-9 Mail. Please excuse my brevity. |
|
@sigmavirus24 #372 created; I matched 0.9's argument style rather than the newer style (i.e. passing an empty string vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where context was always being set to
Noneregardless of the value passed tocreate_status.