Fix exception when merging with empty commit message #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sigmavirus24#370 The GitHub API now requires a param `commit_message` with an empty value '' when merging a pull request. In such case the default value is used as a commit message. Providing an empty data string no longer works.
|
@antoine-g thanks for the pull request. Do you need this backported to 0.9 or are you using the 1.0 prerelease? |
sigmavirus24
added a commit
that referenced
this pull request
Jun 16, 2015
Fix exception when merging with empty commit message
|
We are still using 0.8.2 actually, we plan to upgrade to 0.9 soon. Thanks for your reactivity |
|
Yeah backporting it to 0.9 should be as simple as: That said, if you want to do that and send a PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
As I also experienced the error and the issue has not been active for 2 weeks, I thought I would submit a PR. Feel free to accept or reject this fix. It may conflict with #381.
The GitHub API now requires a param
commit_messagewith an empty value when merging a pull request. In such case the default value is used as a commit message.Providing an empty data string no longer works.