Add support for locking an issue #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e1bfef to
dcc43d8
Compare
| @@ -31,6 +31,10 @@ class Issue(GitHubCore): | |||
|
|
|||
| """ | |||
|
|
|||
| # The Accept header will likely be removable once the feature is out of | |||
| # preview mode. See: https://git.io/vgXmB | |||
| PREVIEW_HEADERS = {'Accept': 'application/vnd.github.the-key-preview+json'} | |||
There was a problem hiding this comment.
Can we make this name a little more descriptive? Like LOCK_PREVIEW_HEADERS
There was a problem hiding this comment.
Fixed in a5b160e
3dd3c1e to
ce82b0d
Compare
|
I've fixed the issues and rebased. |
|
Hey @adrianmoisey , http://github3py.readthedocs.org/en/develop/testing.html Examplehttps://github.com/sigmavirus24/github3.py/blob/develop/tests/integration/test_github.py If you need help with creating the integration test(s), let me know. |
dfe3cf2 to
263c54d
Compare
|
I've added integration tests. Let me know if that's good enough, thanks! |
|
🍰 |
sigmavirus24
added a commit
that referenced
this pull request
Feb 17, 2016
Add support for locking an issue
|
Thanks @adrianmoisey 🍰 |
|
Thanks for the review and help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#572
I'm not sure if this test coverage is enough. I'll need guidance if there is any more.