Skip to content

Add ability to archive a repository #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2018
Merged

Conversation

sigmavirus24
Copy link
Owner

Also add the attribute to determine whether a given Repository is
archived or not. While we're here, let's also trim out some dead
attributes that seem to have come from our PullRequest objects.

Closes gh-752

@sigmavirus24
Copy link
Owner Author

Note: I'm working on re-recording these cassettes.

Copy link
Collaborator

@omgjlk omgjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but did you want to add a couple tests to cover it?

@sigmavirus24
Copy link
Owner Author

Uh, sorry, the tests are failing horribly on this because we need to re-record the cassettes. Looks like accidentally deleting this removed AppVeyor and Travis. Let me add those back.

@sigmavirus24 sigmavirus24 reopened this Jan 4, 2018
@sigmavirus24
Copy link
Owner Author

Finished re-recording the universe. Hopefully now these test will pass :)

@sigmavirus24
Copy link
Owner Author

Ok @omgjlk I added a commit with an explicit test that this works.

@sigmavirus24
Copy link
Owner Author

Once #770 merges, I'm going to close and re-open this to trigger a new merged build.

@sigmavirus24 sigmavirus24 reopened this Jan 7, 2018
@sigmavirus24
Copy link
Owner Author

Ah, the push CI will fail because of this... Let me rebase. sigh

Also add the attribute to determine whether a given Repository is
archived or not. While we're here, let's also trim out some dead
attributes that seem to have come from our PullRequest objects.

Closes gh-752
Remove chitauri-preview header and use SHA. This was found while
re-recording cassettes and wasn't easy to factor out into its own PR.

While fixing the tests, I also found we had tests that were magically
passing earlier (regarding Repository.{source,parent}) so that's fixed
now.
@sigmavirus24 sigmavirus24 merged commit 552b18a into develop Jan 7, 2018
@sigmavirus24 sigmavirus24 deleted the archive-repository branch January 7, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants