Add method to side-step Milestone.labels issue #767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still can't figure out why our integration test for Milestone.labels sometimes completely ignores Betamax and hits GitHub's API. To side-step consistently failing tests, let's generate unique User-Agent strings to see if we can side-step the ratelimit problem on Travis CI.
253fd07 to
dfc8b5f
Compare
It seems interacting with the cassette to start with causes the test to pass... So let's only look at it when we want to see what was going on when it failed.
|
https://travis-ci.org/sigmavirus24/github3.py/jobs/326035335 I was beginning to think that dfc8b5f had "fixed" the issue by touching the cassette prior to a test run. Luckily not. So now I'm wondering if there's something wrong with the code and how we use a session such that we're side-stepping Betamax. |
|
I was looking in all the wrong places. I did some debugging to see if there was a fundamental logic error in the GitHubCore or GitHubIterator objects and found that in fact, that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still can't figure out why our integration test for Milestone.labels
sometimes completely ignores Betamax and hits GitHub's API. To side-step
consistently failing tests, let's generate unique User-Agent strings to
see if we can side-step the ratelimit problem on Travis CI.