Use the issue's Session object on issue.milestone #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without passing in "self" to the Milestone for the issue.milestone attribute, we were getting a completely brand-new GitHubSession. This meant that we were failing to use Betamax which caused our tests to be unreliable and to bypass Betamax while running the test-suite.
This was referenced Jan 7, 2018
|
Perhaps that parameter shouldn't be optional. Hm |
omgjlk
added a commit
to omgjlk/github3.py
that referenced
this pull request
Jan 25, 2018
Unless a session (or a self) is passed through a new session might be created, which can lead to some interesting things. See sigmavirus24#770 This also adds a session class argument for PullDestination and updates the calls to it. A future commit will make the session argument of GitHubCore nonoptional. Related-to: sigmavirus24#771 Signed-off-by: Jesse Keating <omgjlk@github.com>
omgjlk
added a commit
to omgjlk/github3.py
that referenced
this pull request
Jan 25, 2018
Unless a session (or a self) is passed through a new session might be created, which can lead to some interesting things. See sigmavirus24#770 This also adds a session class argument for PullDestination and updates the calls to it. A future commit will make the session argument of GitHubCore nonoptional. Related-to: sigmavirus24#771 Signed-off-by: Jesse Keating <omgjlk@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without passing in "self" to the Milestone for the issue.milestone
attribute, we were getting a completely brand-new GitHubSession. This
meant that we were failing to use Betamax which caused our tests to be
unreliable and to bypass Betamax while running the test-suite.