Skip to content

Allow .refresh to return the longer object #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Conversation

sigmavirus24
Copy link
Owner

This adds logic so that Short* classes can return the fuller
representation. For example:

>>> import github3
>>> users = [(u, u.refresh()) for u in github3.all_users(10)]
>>> for short_user, user in users:
...     assert isinstance(short_user, github3.users.ShortUser)
...     assert isinstance(user, github3.users.User)

Will run without exceptions.

Related to gh-670

This adds logic so that Short* classes can return the fuller
representation. For example:

    >>> import github3
    >>> users = [(u, u.refresh()) for u in github3.all_users(10)]
    >>> for short_user, user in users:
    ...     assert isinstance(short_user, github3.users.ShortUser)
    ...     assert isinstance(user, github3.users.User)

Will run without exceptions.

Related to gh-670
@sigmavirus24 sigmavirus24 merged commit 10d0343 into develop Mar 13, 2018
@sigmavirus24 sigmavirus24 deleted the refresh-updates branch March 13, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant