Skip to content

Fix license link #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2018
Merged

Fix license link #900

merged 2 commits into from
Oct 25, 2018

Conversation

jacquerie
Copy link
Collaborator

This should be the last innocent victim of the switch of the default
branch from develop to master after #898 and #876.

@jacquerie
Copy link
Collaborator Author

jacquerie commented Oct 24, 2018 •
edited
Loading

Interesting, build appears to be broken due to an upstream change
in flake8. Will prepend a commit to fix that.

@jacquerie
Use raw strings where required by flake8
dca3e08
@jacquerie
Fix license link
64ce43f 
This should be the last innocent victim of the switch of the default
branch from `develop` to `master`.
@jacquerie
Copy link
Collaborator Author

jacquerie commented Oct 24, 2018 •
edited
Loading

@sigmavirus24, it appears that flake8 assertions are somewhat misreported. All warnings from https://travis-ci.org/sigmavirus24/github3.py/jobs/445468254#L471 to https://travis-ci.org/sigmavirus24/github3.py/jobs/445468254#L481 refer to the same line:

github3.py/src/github3/github.py

Line 34 in f598e02

'https?://[\w\d\-\.\:]+/\w[\w-]+\w/[\w\._-]+/events/\w+'

Should I open an issue upstream, or is this too small to care about?

omgjlk
omgjlk approved these changes Oct 24, 2018
View reviewed changes
Copy link
Collaborator

@omgjlk omgjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I'll let @sigmavirus24 answer the question + merge.

sigmavirus24
sigmavirus24 approved these changes Oct 25, 2018
View reviewed changes
Copy link
Owner

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigmavirus24 sigmavirus24 merged commit f38e8bf into sigmavirus24:master Oct 25, 2018
@sigmavirus24
Copy link
Owner

Should I open an issue upstream, or is this too small to care about?

No this is the correct behaviour of pycodestyle

@jacquerie jacquerie deleted the fix-license-link branch October 25, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

@omgjlk omgjlk omgjlk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacquerie @sigmavirus24 @omgjlk