What happens if a user requests a per that is not one of day or week? There should probably be some checking around this and a raise if invalid options are passed.

Looking at the API itself, it does require a per argument, so it should be enough to validate that what the function was sent was one of day or week, and then just pass whatever it is into the params.

Maybe here, just have an else block that raises an error about invalid arguments.

Sounds reasonable. Will do.

Although, to be consistent with this behavior, you'll want to update create_blob(), create_status(), create_tag() and archive() in the Repository class as well. All these functions accept parameters with a string value from some allowed set, and don't fail if the value is outside of that set (just silently ignore the parameter).

That'd be a nice follow up PR.

Or maybe we can just follow the example. Presumably the API itself will return the error back to the user, and github3.py will surface it accordingly. Worth giving it a test! If the error comes back through nicely then less code is better code :D

Same thing here about validating a proper argument was sent.

This looks like the right error to raise. But when adding a Raise we should update the function doc string. I was just looking at this example and saw the docs were updated there.

Of course, thanks for catching that.