Skip to content

Use trustconfig throughout the project #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jku opened this issue Apr 30, 2025 · 1 comment
Open

Use trustconfig throughout the project #1359

jku opened this issue Apr 30, 2025 · 1 comment
Assignees
@jku
Labels
enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented Apr 30, 2025 •
edited
Loading

Description

Currently various subcomponents have different ways to initialize them for a specific sigstore instance: I think now is a good time to simplify that and just always provide a TrustConfig to those subcomponents

This still requires a bit of special casing (since production does not yet have the SigningConfig part of TrustConfig) but we can handle that in a single place

I'm looking at how much work this is right now: I assume I will have a PR soon
@jku jku added the enhancement New feature or request label Apr 30, 2025
@jku jku self-assigned this Apr 30, 2025
@jku
Copy link
Member Author

jku commented Apr 30, 2025 •
edited
Loading

Implementation looks very reasonable and probably allows us to remove a lot of staging() and production() methods

I will hold making the PR until staging has the signingconfig we need: that way only prod needs the hard coded special case I mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jku jku

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jku