Skip to content

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 20, 2022

Closes #161.

Signed-off-by: William Woodruff william@trailofbits.com

Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review July 20, 2022 19:40
@woodruffw woodruffw self-assigned this Jul 20, 2022
@woodruffw woodruffw requested a review from di July 20, 2022 19:40
@woodruffw
Copy link
Member Author

Example created issue: #166.

@woodruffw
Copy link
Member Author

One thing: this will create a new issue each time the staging tests fail, which could happen several times (on the cron schedule) before a fix is implemented and applied. I'm not sure if that's worth addressing now.

@di
Copy link
Member

di commented Jul 20, 2022

One thing: this will create a new issue each time the staging tests fail, which could happen several times (on the cron schedule) before a fix is implemented and applied. I'm not sure if that's worth addressing now.

Might get annoying if staging is broken for a long time, but I figure we can cross that bridge when we get to it.

@woodruffw woodruffw merged commit ad1f03d into main Jul 20, 2022
@woodruffw woodruffw deleted the ww/create-issue-when-staging-fails branch July 20, 2022 21:49
@jku
Copy link
Member

jku commented Jul 22, 2022

I'm a bit late but if you want to avoid 3rd party actions, this is also a single call with actions/github-script. Example:
https://github.com/theupdateframework/python-tuf/blob/develop/.github/workflows/maintainer-permissions-reminder.yml

@jku
Copy link
Member

jku commented Jul 22, 2022

One thing: this will create a new issue each time the staging tests fail, which could happen several times (on the cron schedule) before a fix is implemented and applied. I'm not sure if that's worth addressing now.

Might get annoying if staging is broken for a long time, but I figure we can cross that bridge when we get to it.

when you do, a rough bridge is here: https://github.com/theupdateframework/python-tuf/blob/develop/.github/workflows/specification-version.yml 😉

@woodruffw
Copy link
Member Author

Nice! Yeah, avoiding a third party action where we can do so conveniently seems like an easy win to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify on CI failure
3 participants