Skip to content

Makefile: Make lint exit non-zero with unstaged changes #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2022
Merged

Makefile: Make lint exit non-zero with unstaged changes #169

merged 3 commits into from
Jul 21, 2022

Conversation

tetsuo-cpp
Copy link
Contributor

Closes #168

@tetsuo-cpp
Makefile: Make lint exit non-zero with unstaged changes
977c3ee 
Signed-off-by: Alex Cameron <alex.cameron@trailofbits.com>
tetsuo-cpp
tetsuo-cpp commented Jul 21, 2022
View reviewed changes
@tetsuo-cpp tetsuo-cpp requested a review from woodruffw July 21, 2022 05:20
@tetsuo-cpp
Copy link
Contributor Author

When we merge #167 in, the lint workflow should start passing again.

@woodruffw woodruffw merged commit 0452796 into main Jul 21, 2022
@woodruffw woodruffw deleted the alex/lint-exit-code branch July 21, 2022 14:10
di
di reviewed Jul 21, 2022
View reviewed changes
@di di mentioned this pull request Jul 21, 2022
Closed
@woodruffw woodruffw mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di left review comments

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Reformatting from Black does not break lint workflow
3 participants
@tetsuo-cpp @di @woodruffw