API tweak to allow further external verification #182
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a discussion starter for #157
Summary
It is currently not possible to use sigstore-python to verify the signatures made with a GitHub Actions certificate -- or rather it's not possible to verify any meaningful claims made by GitHub (like which project is responsible or what workflow was used). This is true for both the CLI tool and the API.
This change keeps CLI as is, but tweaks the API so that callers of verify() can do their own verification of the certificate contents after sigstore-python is happy with it.
Release Notes
Documentation
The change allows an external developer to write (as an example) this code to verify GitHub specific claims outside the sigstore-python codebase: