Skip to content

Support --cert-identity #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2022
Merged

Support --cert-identity #289

merged 2 commits into from
Nov 3, 2022

Conversation

woodruffw
Copy link
Member

Closes #108.

@woodruffw
_cli, _verify: add --cert-identity
41b018b 
Closes #108.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
README: sigstore verify --help
1b9dc4e 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw added component:cli CLI components component:verification Core verification functionality labels Nov 3, 2022
@woodruffw woodruffw requested review from di and tetsuo-cpp November 3, 2022 15:07
@woodruffw woodruffw self-assigned this Nov 3, 2022
@woodruffw woodruffw marked this pull request as ready for review November 3, 2022 15:34
This was referenced Nov 3, 2022
Merged
Closed
@woodruffw
Copy link
Member Author

NB: We'll also need to update the GitHub Action, once this makes it into a release.

@tetsuo-cpp
Copy link
Contributor

NB: We'll also need to update the GitHub Action, once this makes it into a release.

Sure, I can do that.

Let's cut a release once #288 makes its way in.

tetsuo-cpp
tetsuo-cpp approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit 85a96dd into main Nov 3, 2022
@tetsuo-cpp tetsuo-cpp deleted the ww/cert-identity branch November 3, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetsuo-cpp tetsuo-cpp tetsuo-cpp approved these changes

@di di Awaiting requested review from di

Assignees

@woodruffw woodruffw

Labels
component:cli CLI components component:verification Core verification functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: alias --cert-email as --cert-identity/--cert-san
2 participants
@woodruffw @tetsuo-cpp