workflows/staging-tests: add missing identity check #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
|
I'm going to push up a temporary commit enabling it on this branch to confirm it works, then revert. |
Signed-off-by: William Woodruff <william@trailofbits.com>
di
previously approved these changes
Nov 21, 2022
Might be nice to have this say what the SAN actually is/are. |
Signed-off-by: William Woodruff <william@trailofbits.com>
Yeah, I was thinking about how best to expose this: the cert can potentially have multiple SANs of multiple types (I believe Fulcio currently only allows one SAN, but maybe we shouldn't assume that?). I'll do that in a follow-up. |
Signed-off-by: William Woodruff <william@trailofbits.com>
|
Confirmed that the conformance suite is passing, so this should be good to go. |
|
Opened #309 for the failure reason side. |
di
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#299 made
--cert-identitymandatory, so this should fix the staging tests by using it.Fixes #306.
Signed-off-by: William Woodruff william@trailofbits.com