-
Notifications
You must be signed in to change notification settings - Fork 56
CHANGELOG: record changes #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
/gcbrun |
di
approved these changes
Jan 25, 2023
jleightcap
pushed a commit
that referenced
this pull request
Jan 31, 2023
Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com>
jleightcap
pushed a commit
that referenced
this pull request
Jan 31, 2023
Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: Jack Leightcap <jack.leightcap@trailofbits.com>
emboman13
pushed a commit
to emilejbm/sigstore-python
that referenced
this pull request
Feb 2, 2023
Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: emboman13 <embo1013@yahoo.com>
woodruffw
added a commit
that referenced
this pull request
Feb 14, 2023
* class prototype and script to find instances to change * script added * Set up newtype file with example newTypes * added newtypes to _util.py * renamed newtypes, added keyID * deletion of old file * added hexstr newtype and implemented newtypes for SigningResults * added newtypes to verify/models.py * renamed newtypes to follow standardized format * moved newtypes into _util * deleted newtypes.py * Changed sign.py to use _utils and set up basic implementation in verifier * build(deps-dev): update ruff requirement from <0.0.226 to <0.0.229 (#466) Updates the requirements on [ruff](https://github.com/charliermarsh/ruff) to permit the latest version. - [Release notes](https://github.com/charliermarsh/ruff/releases) - [Changelog](https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](astral-sh/ruff@v0.0.18...v0.0.228) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emboman13 <embo1013@yahoo.com> * build(deps-dev): update ruff requirement from <0.0.229 to <0.0.231 (#468) Updates the requirements on [ruff](https://github.com/charliermarsh/ruff) to permit the latest version. - [Release notes](https://github.com/charliermarsh/ruff/releases) - [Changelog](https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](astral-sh/ruff@v0.0.18...v0.0.230) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emboman13 <embo1013@yahoo.com> * build(deps-dev): update ruff requirement from <0.0.231 to <0.0.232 (#469) Updates the requirements on [ruff](https://github.com/charliermarsh/ruff) to permit the latest version. - [Release notes](https://github.com/charliermarsh/ruff/releases) - [Changelog](https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](astral-sh/ruff@v0.0.18...v0.0.231) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emboman13 <embo1013@yahoo.com> * Initial Sigstore bundle support (#465) * Initial Sigstore bundle support Signed-off-by: William Woodruff <william@trailofbits.com> * README: update `--help` texts Signed-off-by: William Woodruff <william@trailofbits.com> * sign: fix bundle generation Certs are base64'd DER, not PEM, and the canonicalized_body is the log entry body, not the canonicalized contents that the SET is signed over. Signed-off-by: William Woodruff <william@trailofbits.com> * sign: remove TODO Signed-off-by: William Woodruff <william@trailofbits.com> * sign: update TODO Signed-off-by: William Woodruff <william@trailofbits.com> * _cli: Make `--bundle` refer to a path and create a `--no-bundle` flag to control whether Sigstore bundles are emitted by default Signed-off-by: Alex Cameron <asc@tetsuo.sh> * _cli: Move variable to correct scope Signed-off-by: Alex Cameron <asc@tetsuo.sh> * _cli: Reword warnings for bundle flags Signed-off-by: Alex Cameron <asc@tetsuo.sh> * README: Fix sign example Signed-off-by: Alex Cameron <asc@tetsuo.sh> * README: Update verify invocations Signed-off-by: Alex Cameron <asc@tetsuo.sh> * README: Fix line breaks Signed-off-by: Alex Cameron <asc@tetsuo.sh> * _cli: fix sig output Signed-off-by: William Woodruff <william@trailofbits.com> * _cli: fix sig check, take 2 Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: Alex Cameron <asc@tetsuo.sh> Co-authored-by: Alex Cameron <asc@tetsuo.sh> Signed-off-by: emboman13 <embo1013@yahoo.com> * CHANGELOG: record changes (#470) Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: emboman13 <embo1013@yahoo.com> * class prototype and script to find instances to change Signed-off-by: emboman13 <embo1013@yahoo.com> * script added Signed-off-by: emboman13 <embo1013@yahoo.com> * Set up newtype file with example newTypes Signed-off-by: emboman13 <embo1013@yahoo.com> * renamed newtypes, added keyID Signed-off-by: emboman13 <embo1013@yahoo.com> * deletion of old file Signed-off-by: emboman13 <embo1013@yahoo.com> * added hexstr newtype and implemented newtypes for SigningResults Signed-off-by: emboman13 <embo1013@yahoo.com> * added newtypes to _util.py Signed-off-by: emboman13 <embo1013@yahoo.com> * renamed newtypes to follow standardized format Signed-off-by: emboman13 <embo1013@yahoo.com> * added newtypes to verify/models.py Signed-off-by: emboman13 <embo1013@yahoo.com> * moved newtypes into _util Signed-off-by: emboman13 <embo1013@yahoo.com> * deleted newtypes.py Signed-off-by: emboman13 <embo1013@yahoo.com> * Changed sign.py to use _utils and set up basic implementation in verifier Signed-off-by: emboman13 <embo1013@yahoo.com> * added newtypes to sigstore/veriry/models.py * updated newtypes in verify/models.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * Revert "updated newtypes in verify/models.py" This reverts commit f767d7a. * Encapsulation of NewTypes in my share of files Creation of new type 'dercert' that masks DER encoded bytes. Focus on changing types in files within sigstore/_internal/. Reformat, lint lint is successful. 103 Tests pass, 8 are skipped, 2 fail. * Removed an incorrect b64str newtype in models.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * "added newtypes to _internal/rekor/client.py" Signed-off-by: omartounsi7 <otounsi@purdue.edu> * "fixed type errors in sign.py" Signed-off-by: omartounsi7 <otounsi@purdue.edu> * Added a b64str newtype in verify/models.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * added a b64str newtype in verify/verifier.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * added a b64str newtype to _internal/fulcio/client.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * added a b64str newtype in _internal/oidc/oauth.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * added a b64str newtype in _internal/rekor/client.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * deleted script Signed-off-by: omartounsi7 <otounsi@purdue.edu> * fixed some type errors * changed keyid to KeyID Signed-off-by: omartounsi7 <otounsi@purdue.edu> * anged hexstr to HexStr Signed-off-by: omartounsi7 <otounsi@purdue.edu> * changed b64str to B64Str Signed-off-by: omartounsi7 <otounsi@purdue.edu> * changed pemcert to PEMCert Signed-off-by: omartounsi7 <otounsi@purdue.edu> * changed dercert to DERCert Signed-off-by: omartounsi7 <otounsi@purdue.edu> * added docstrings to newtypes in _utils.py Signed-off-by: omartounsi7 <otounsi@purdue.edu> * Update sigstore/_utils.py Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: omartounsi7 <62721212+omartounsi7@users.noreply.github.com> * Update sigstore/_utils.py Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: omartounsi7 <62721212+omartounsi7@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: emboman13 <embo1013@yahoo.com> Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: Alex Cameron <asc@tetsuo.sh> Signed-off-by: omartounsi7 <otounsi@purdue.edu> Signed-off-by: omartounsi7 <62721212+omartounsi7@users.noreply.github.com> Co-authored-by: emboman13 <embo1013@yahoo.com> Co-authored-by: omartounsi7 <otounsi@purdue.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: William Woodruff <william@trailofbits.com> Co-authored-by: Alex Cameron <asc@tetsuo.sh> Co-authored-by: omartounsi7 <62721212+omartounsi7@users.noreply.github.com> Co-authored-by: William Woodruff <william@yossarian.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed these in #465.