Skip to content

Conversation

di
Copy link
Member

@di di commented May 17, 2022

As a follow-on to #88, and towards #31, support service account impersonation, which makes it possible to use Google Cloud Build.

Also adds documentation for ambient credential detection.

@di di requested a review from woodruffw May 17, 2022 19:05
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw added the component:signing Core signing functionality label May 17, 2022
@woodruffw woodruffw merged commit ccb00ad into sigstore:main May 17, 2022
@di di deleted the support-gcp-impersonation branch May 17, 2022 20:56
@di di mentioned this pull request May 17, 2022
5 tasks
javanlacerda pushed a commit to javanlacerda/sigstore-python that referenced this pull request Feb 23, 2024
* cli: move oidc token into pytest

Signed-off-by: Jack Leightcap <jack.leightcap@trailofbits.com>

* cli: github token threading

Signed-off-by: Jack Leightcap <jack.leightcap@trailofbits.com>

---------

Signed-off-by: Jack Leightcap <jack.leightcap@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:signing Core signing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants