Skip to content

oauth: Fix race in OIDC token retrieval #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2022
Merged

oauth: Fix race in OIDC token retrieval #99

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
881ccbb
oauth: Fix race in OIDC token retrieval
tetsuo-cpp May 31, 2022
42384ac
oauth: Fix lint
tetsuo-cpp May 31, 2022
a39b2c7
oidc/oauth: `return None`
woodruffw May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sigstore/_internal/oidc/oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ def log_message(self, _format: str, *_args: Any) -> None:

def do_GET(self) -> None:
server = cast(RedirectServer, self.server)

# If the auth response has already been populated, the main thread will be stopping this
# thread and accessing the auth response shortly so we should stop servicing any requests.
if not server.active:
return None

r = urllib.parse.urlsplit(self.path)

# Handle auth response
Expand Down