This might enable building the core library under Visual Studio 2015 #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeiser
approved these changes
Jun 29, 2020
|
@jkeiser It is ugly but I think that Visual Studio 2015 had bugs in its C++11 support. This is to be expected when you first adopt a standard. The std::unique_ptr thing does look like a bug. The compiler tells you that there is no version of the constructor with two parameters (i.e., with a deleter), but this is a lie as per the Visual Studio 2015 documentation. There is probably something else going on... but our code, the code that causes Visual Basic to complain, is flat out textbook C++11 as far as I can see. Of course, I can investigate deeper but my interest for working out the oddities of old compilers is not great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazingly, if you get the very latest Visual Studio 2015, it seems to work.
(The initial Visual Studio 2015 does not work.)
Fixes #999