Skip to content

This example in our documentation would not compile #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

lemire
Copy link
Member

@lemire lemire commented Jun 29, 2020

No description provided.

@lemire lemire requested a review from jkeiser June 29, 2020 20:06
@jkeiser
Copy link
Member

jkeiser commented Jun 29, 2020

Rust's "rustdoc" actually has a mode where it will compile all your code examples, and even gives you ways to write "preamble" code that helps the example run but doesn't show up in the published docs. I wonder if doxygen (or some other doc generator) has this for C++.

@lemire
Copy link
Member Author

lemire commented Jun 29, 2020

Rust's "rustdoc" actually has a mode where it will compile all your code examples, and even gives you ways to write "preamble" code that helps the example run but doesn't show up in the published docs. I wonder if doxygen (or some other doc generator) has this for C++.

This has the smell of a "solved problem". I know people who wrote LaTeX documents with code in it that would be run and tested as part of the build.

But as long as we are careful (and we are), we will find most bugs, I think.

@lemire lemire merged commit 1fd30db into master Jun 29, 2020
@lemire lemire deleted the dlemire/correcting_mismatched_example branch June 29, 2020 20:25
@jkeiser
Copy link
Member

jkeiser commented Jun 29, 2020

Yeah, at the moment it's less worth investing in than most of our stuff. We already have more documentation tests than most, even if it can get out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants