Skip to content

Resolves issue 186 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Resolves issue 186 #383

merged 2 commits into from
Dec 2, 2019

Conversation

lemire
Copy link
Member

@lemire lemire commented Dec 2, 2019

@lemire
Copy link
Member Author

lemire commented Dec 2, 2019

This PR removes 35,000 lines of code with basically no downside. Can anyone beat this?

cc @jkeiser @piotte13

@lemire
Copy link
Member Author

lemire commented Dec 2, 2019

Fails to compile in some conditions...

@piotte13
Copy link
Collaborator

piotte13 commented Dec 2, 2019

+1
Good job!

@lemire
Copy link
Member Author

lemire commented Dec 2, 2019

Ok. It was a case of a missing "}".

@lemire lemire merged commit 1211c01 into master Dec 2, 2019
@jkeiser
Copy link
Member

jkeiser commented Dec 2, 2019

Super happy about the smaller include file and thus public surface :)

@lemire
Copy link
Member Author

lemire commented Dec 2, 2019

@jkeiser This has been on my todo list for nearly 6 months. I am really glad it is done.

@jkeiser jkeiser deleted the lemire/issue186 branch December 24, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants