Skip to content

Fix #420 #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix #420 #421

merged 1 commit into from
Jan 9, 2020

Conversation

ukabuer
Copy link
Contributor

@ukabuer ukabuer commented Dec 24, 2019

Fix #420

According to the documentation, move_to_key() and move_to_index() should go back to the original depth if the desired key is not found.

@lemire
Copy link
Member

lemire commented Dec 24, 2019

Thanks. To be reviewed.

@jkeiser
Copy link
Member

jkeiser commented Dec 28, 2019

Q: do we have benchmarking for the iterator? Seems like a lot of people will interact with JSON via it.

@lemire
Copy link
Member

lemire commented Dec 28, 2019

We do have some benchmarks. Look in the benchmark directory. We have not done work to optimize it... I suspect that switching to a flat 16-byte tape might help.

@lemire
Copy link
Member

lemire commented Jan 8, 2020

@DBJDBJ Would you have a look?

@DBJDBJ
Copy link
Contributor

DBJDBJ commented Jan 8, 2020

@lemire OK

I am looking at ~/simdjson/parsedjson.h and ~/simdjson/parsedjsoniterator.h, right?

@lemire
Copy link
Member

lemire commented Jan 9, 2020

The PR diff is at https://github.com/lemire/simdjson/pull/421/files

@lemire
Copy link
Member

lemire commented Jan 9, 2020

The issue at #420

@DBJDBJ
Copy link
Contributor

DBJDBJ commented Jan 9, 2020

"...switching to a flat 16-byte tape..."

@lemire, tape is a member of ParsedJson,

class ParsedJson {
. . .
std::unique_ptr<uint64_t[]> tape;
. . .
} ;

I assume you are asking me to look into improving ParsedJson and ParsedJson::BasicIterator ? Thus, I have asked about ~/simdjson/parsedjson.h and ~/simdjson/parsedjsoniterator.h ...

On the fix for #420 and #421, I can only guess, which somehow I would not like to do :) (ps: I would like to ask the requestor if he has proven the fix by running the tests . I am not clear who has found and proven the issue.)

@lemire lemire merged commit 773883c into simdjson:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move_to_key & move_to_index not going back to the uppper depth if the desired key is not found
4 participants