Make checkperf work on Windows #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d93b99 to
085b410
Compare
|
I did this a little differently from how I did the competition dependencies; I made it so it would only pull and build the repository if you actually specify the checkperf target, rather than doing it at configure time. This doesn't seem to be the usual pattern, but I like it better. I hate paying for stuff I don't use. |
3d4cdb7 to
71eb24b
Compare
71eb24b to
73bfc8d
Compare
|
@lemire this one also downsizes our Windows CI runs to 3, still checking all individual options but not trying as many combinations. |
lemire
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
This uses -DSIMDJSON_CHECKPERF_BRANCH=jkeiser/parse-t, which is a branch just containing the changes to enable parse -t on Windows. It will be removed on the next checkin (we can't run it against master until it supports parse -t).