This introduces a new option to forcefully disable threads for people who also want them enabled #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeiser
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people want to compile simdjson with thread support, and yet they do not want simdjson to use threads. There is no runtime way to do this right now. This PR introduces a compile-time "overwrite" option (SIMDJSON_DO_NOT_USE_THREADS_NO_MATTER_WHAT) that would overwrite thread support and prevent simdjson from using threads, even if it is compiled with thread support.
This a temporary compile-time option. I expect that we will offer runtime control in the future.
Fixes #988